audio: add items to AudioResponseFormat enum #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 17 17
Lines 670 670
=======================================
Hits 638 638
Misses 22 22
Partials 10 10
|
vvatanabe
reviewed
Jun 16, 2023
| AudioResponseFormatJSON AudioResponseFormat = "json" | ||
| AudioResponseFormatText AudioResponseFormat = "text" | ||
| AudioResponseFormatSRT AudioResponseFormat = "srt" | ||
| AudioResponseFormatVerboseJSON AudioResponseFormat = "verbose_json" |
There was a problem hiding this comment.
@romazu What format is verbose_json? If it is json, you may need to add it to the conditions of the function below.
// HasJSONResponse returns true if the response format is JSON.
func (r AudioRequest) HasJSONResponse() bool {
return r.Format == "" || r.Format == AudioResponseFormatJSON
}
Refs:
https://github.com/sashabaranov/go-openai/blob/master/audio.go#L97-L100
There was a problem hiding this comment.
Yes, you are right, it's a json in the following format:
{
"task": "transcribe",
"language": "english",
"duration": 10.0,
"segments": [
{
"id": 0,
"seek": 0,
"start": 0.0,
"end": 10.16,
"text": " Chapter 1 Looming",
"tokens": [
50364,
18874,
502,
6130,
10539,
50872
],
"temperature": 0.0,
"avg_logprob": -0.6817335401262555,
"compression_ratio": 0.68,
"no_speech_prob": 0.01032273843884468,
"transient": false
}
],
"text": "Chapter 1 Looming"
}
I also expanded AudioResponse struct to accommodate for this.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "text" and "verbose_json" output formats.
See reference:
https://platform.openai.com/docs/api-reference/audio/create